search

redhat-cop / cluster-lifecycle

Sample Repository that shows state management
Creative Commons Attribution Share Alike 4.0 International
4 stars 8 forks source link

Added inventory to deploy an acme controller #5

Closed sabre1041 closed 7 years ago

sabre1041 commented 7 years ago

Inventory to deploy an acme controller leveraging the openshift-applier

sabre1041 commented 7 years ago

@pabrahamsson thanks for finding those issues with the template. They have been corrected.

etsauer commented 7 years ago

@pabrahamsson @sabre1041 is this good to merge?

etsauer commented 7 years ago

@sabre1041 could you add "menu items" to the main readme to point to the cakephp and acme stuff?

sabre1041 commented 7 years ago

@etsauer updated the README

pabrahamsson commented 7 years ago

@etsauer I haven't had a chance to test this out yet and I'm also not terribly familiar with Let's Encrypt. Do we need testing or are my two :eyes: enough? If yes then LGTM.

oybed commented 7 years ago

This is something that’s very timely. I’ll add it to my list of items to test right away as we need this for Labs ASAP. Alternatively; just merge and we can submit any updates in follow-up PRs.

etsauer commented 7 years ago

@sabre1041 @pabrahamsson @oybed anyone tested this yet?

sabre1041 commented 7 years ago

@oybed Addressed your feedback. Please review

oybed commented 7 years ago

LGTM - merging