search

redhat-cop / controller_configuration

A collection of roles to manage Ansible Controller and previously Ansible Tower
https://galaxy.ansible.com/infra/controller_configuration
GNU General Public License v3.0
259 stars 134 forks source link

object_diff duplicates entries of workflow_job_templates #843

Open dbk-rabel opened 1 month ago

dbk-rabel commented 1 month ago

Hi.

Not sure, if this is a known issue. But it seems, that object_diff cannot handle workflow_job_templates properly.

In our Playbook we always run the roles to create objects, then object_diff and then the other roles again to delete objects.

From the logs with two workflow job templates:

TASK [infra.controller_configuration.workflow_job_templates : Managing Workflows] ***
ok: [localhost] => (item=Create/Update Workflow wt_debeka_cifs_create)
ok: [localhost] => (item=Create/Update Workflow wt_debeka_lun_create)
ok: [localhost] => (item=Create/Update Workflow wt_debeka_nfs_create)

...

object_diff

...

TASK [infra.controller_configuration.workflow_job_templates : Managing Workflows] ***
ok: [localhost] => (item=Create/Update Workflow wt_debeka_cifs_create)
ok: [localhost] => (item=Create/Update Workflow wt_debeka_lun_create)
ok: [localhost] => (item=Create/Update Workflow wt_debeka_nfs_create)
ok: [localhost] => (item=Create/Update Workflow wt_debeka_cifs_create)
ok: [localhost] => (item=Create/Update Workflow wt_debeka_lun_create)
ok: [localhost] => (item=Create/Update Workflow wt_debeka_nfs_create)
ok: [localhost] => (item=Create/Update Workflow wt_debeka_cifs_create)
ok: [localhost] => (item=Create/Update Workflow wt_debeka_lun_create)
ok: [localhost] => (item=Create/Update Workflow wt_debeka_nfs_create)
ok: [localhost] => (item=Create/Update Workflow wt_debeka_cifs_create)
ok: [localhost] => (item=Create/Update Workflow wt_debeka_lun_create)
ok: [localhost] => (item=Create/Update Workflow wt_debeka_nfs_create)
ok: [localhost] => (item=Create/Update Workflow wt_debeka_cifs_create)
ok: [localhost] => (item=Create/Update Workflow wt_debeka_lun_create)
ok: [localhost] => (item=Create/Update Workflow wt_debeka_nfs_create)
ok: [localhost] => (item=Create/Update Workflow wt_debeka_cifs_create)
ok: [localhost] => (item=Create/Update Workflow wt_debeka_lun_create)
ok: [localhost] => (item=Create/Update Workflow wt_debeka_nfs_create)
ok: [localhost] => (item=Create/Update Workflow wt_debeka_cifs_create)
ok: [localhost] => (item=Create/Update Workflow wt_debeka_lun_create)
ok: [localhost] => (item=Create/Update Workflow wt_debeka_nfs_create)
ok: [localhost] => (item=Create/Update Workflow wt_debeka_cifs_create)
ok: [localhost] => (item=Create/Update Workflow wt_debeka_lun_create)
ok: [localhost] => (item=Create/Update Workflow wt_debeka_nfs_create)
ok: [localhost] => (item=Create/Update Workflow wt_debeka_cifs_create)
ok: [localhost] => (item=Create/Update Workflow wt_debeka_lun_create)
ok: [localhost] => (item=Create/Update Workflow wt_debeka_nfs_create)
ok: [localhost] => (item=Create/Update Workflow wt_debeka_cifs_create)
ok: [localhost] => (item=Create/Update Workflow wt_debeka_lun_create)
ok: [localhost] => (item=Create/Update Workflow wt_debeka_nfs_create)
dbk-rabel commented 1 month ago

PS: I know the object_diff role needs refactoring anyways. Just wanted to note that this is also an issue.