search

redhat-cop / controller_configuration

A collection of roles to manage Ansible Controller and previously Ansible Tower
https://galaxy.ansible.com/infra/controller_configuration
GNU General Public License v3.0
263 stars 136 forks source link

Please clarify status of simplified_workflow_nodes #853

Open dbk-rabel opened 2 months ago

dbk-rabel commented 2 months ago

Hello.

From https://github.com/redhat-cop/controller_configuration/issues/297 it looks like simplified_workflow_nodes is old and should not be used anymore. From https://github.com/redhat-cop/controller_configuration/blob/devel/roles/workflow_job_templates/README.md that does not seem to be the case.

Could you clarify if one should use simplified_workflow_nodes? And if not: What's the difference between workflow_nodes and simplified_workflow_nodes? Are they just interchangeable?

Yours David

sean-m-sullivan commented 1 month ago

we can update the wording and likely need to put in that they are depreciated. It is a holdover as removing it would be a breaking change, but we recommend using the workflow schema option. In other words we likely need to update the readme to make this clear that this is not recomended.

They are not interchangeable as the simplified was an OLD format predating even the ansible.controller collection, when the workflow_nodes option was added to the workflow job template module, I tried to make it interchangeable and it became a spaghetti code and abandoned. The current model is the one that is outputed from the awx-cli command line tool or export modules.

An in depth blog article about using the workflow_nodes is here: https://www.redhat.com/en/blog/automation-controller-workflow-deployment-as-code

djdanielsson commented 1 month ago

I think we should officially depreciate it in the next release and then remove it as a breaking change soon after