search

redhat-cop / egressip-ipam-operator

egressip-ipam-operator
Apache License 2.0
34 stars 23 forks source link

Fixed kube-rbac-proxy container #72

Closed sabre1041 closed 3 years ago

sabre1041 commented 3 years ago

Updated kube-rbac-proxy to make use of coreos based container

raffaelespazzoli commented 3 years ago

I'm not sure this is what we want to do. Please talk to Trevor, he was looking into this problem.

On Wed, Jun 9, 2021, 8:41 PM Andrew Block @.***> wrote:

@sabre1041 https://github.com/sabre1041 requested your review on: #72 https://github.com/redhat-cop/egressip-ipam-operator/pull/72 Fixed kube-rbac-proxy container.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/redhat-cop/egressip-ipam-operator/pull/72#event-4868729021, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABPERXBUGRC33DOJ3R7TDN3TSAX6ZANCNFSM46NHYSHQ .

trevorbox commented 3 years ago

I'm not sure this is what we want to do. Please talk to Trevor, he was looking into this problem. … On Wed, Jun 9, 2021, 8:41 PM Andrew Block @.***> wrote: @sabre1041 https://github.com/sabre1041 requested your review on: #72 <#72> Fixed kube-rbac-proxy container. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#72 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABPERXBUGRC33DOJ3R7TDN3TSAX6ZANCNFSM46NHYSHQ .

Let's do this for now. See https://github.com/redhat-cop/egressip-ipam-operator/issues/71#issuecomment-859129029