Open garethahealy opened 6 months ago
resolved comments
@sabre1041 good to merge? or want anything else changed?
@sabre1041 good to merge?
gareth, I think theres's value to this PR. How hard would it be to test against multiple repos? A sort of running this a matrix of repos. The important repos are: vault-config, namespace-config, patch-operator, cert-utils. And of course group-sync which you already have. Also can we make this periodic, so it runs every week or so? This way we should get an early warning when build stop to work.
@raffaelespazzoli ; i can look to do that, not sure when I will have time (maybe in a few weeks), so can we get this PR merged? and then I'll do that suggestion on another PR.
@garethahealy we have a things we want to clear with our operators first. then we can look to integrate this PR in
Any PRs to the workflows in this repo have to be manually tested outside of the repo. I've done this by changing a consumer repo (i.e.: redhat-cop/group-sync-operator) to use the new version of my fork.
This change adds the ability to run the PR workflow against
redhat-cop/group-sync-operator
, improving confidence any changes to the PR workflow are OK and will at least work againstredhat-cop/group-sync-operator
The new
input
is to allow the workflow to work against another repo, since this one doesn't contain any code.