redhat-cop / gitops-catalog

Tools and technologies that are hosted on an OpenShift cluster
Apache License 2.0
317 stars 157 forks source link

knative-kafka-instance.yaml is not in the intended directory #26

Closed hupiper closed 3 years ago

hupiper commented 3 years ago

The kustomization file for the 4.7 overlay has this reference for a resource:

resources: - knative-kafka-instance.yaml

There is no file like that in the directory.

strangiato commented 3 years ago

This was resolved by #25 and merged a few hours ago so you should be good to go!

hupiper commented 3 years ago

Thanks for looking into that! I should have been more clear, I'm referencing the openshift-serverless-operator catalog entry.

I still get the same error because I am invoking the overlay this way: oc apply -k https://github.com/redhat-canada-gitops/catalog/openshift-serverless-operator/overlays/4.7, and the reference in that kustomization file is:

resources: - knative-kafka-instance.yaml

There is no file like that in this catalog entry.

strangiato commented 3 years ago

Ah, I see. Yeah, that was probably a left over copy and paste error when I set those up. I went ahead and submitted a PR to fix that.

pittar commented 3 years ago

PR merged. Thanks @hupiper for opening the issue, and thanks @strangiato for fixing it!