redhat-cop / helm-charts

Helm Charts Repository
https://redhat-cop.github.io/helm-charts
Apache License 2.0
104 stars 83 forks source link

Support for enabling insecure connections into Gitea #529

Closed Lucifergene closed 3 months ago

Lucifergene commented 3 months ago

What is this PR About?

This PR enables users to specify whether they want to allow insecure connections to the Gitea instance. This becomes important when a user has started a Gitea server in a cluster and they are trying to create an application from one of the repositories of the Gitea server in the same cluster. The issue that is observed in this case is the build is failing as git clone command is not able to access the repository URL as by default all insecure connections are blocked. One of the solutions is to install proper SSL certificates, but its complicated for simple development practises.

P.S. I am from the Openshift Developer Console UI Team. Currently, we are implementing Gitea as one of the Git Providers into the "Import Forms". We are using this helm chart to install Gitea on the cluster for development. This update would help me in the process.

How do we test this?

cc: @redhat-cop/day-in-the-life

ckavili commented 3 months ago

can you also please update Chart version in Chart.yaml? πŸ™ tests are not happy ☺️

Lucifergene commented 3 months ago

@ckavili Thanks. I have updated the chart version :)

ckavili commented 3 months ago

thanks! LGTM πŸ™Œ