redhat-cop / infra.aap_configuration

A collection of roles to manage Ansible Automation Platform 2.5+ with code
https://galaxy.ansible.com/infra/aap_configuration
GNU General Public License v3.0
276 stars 141 forks source link

Mandatory rrule in shedules #584

Closed jpcarmona closed 1 year ago

jpcarmona commented 1 year ago

Summary

Hello!

Could it be that the "rrule" parameter in the "schedules" role does not have to be mandatory? https://github.com/redhat-cop/controller_configuration/blob/devel/roles/schedules/tasks/main.yml#L7

In awx.awx and ansible.controller collections do not appear as required: https://docs.ansible.com/ansible/latest/collections/awx/awx/schedule_module.html#parameter-rrule https://console.redhat.com/ansible/automation-hub/repo/published/ansible/controller/content/module/schedule/?version=4.3.0

Issue Type

Ansible, Collection, Controller details

ansible.controller              4.3.0  
ansible.utils                   2.5.0  
awx.awx                         21.14.0 
community.general               4.4.0  
infra.controller_configuration  2.3.1_devel 

ERROR


TASK [infra.controller_configuration.schedules : Add Controller Schedule] ************************************************************************************************************************************
fatal: [localhost]: FAILED! => {"msg": "Mandatory variable 'rrule'  not defined."}

STEPS TO REPRODUCE


- name: "Delete schedule"
  ansible.builtin.include_role:
    name: "schedules"
  vars:
    controller_schedules:
      - name: "schedule_to_delete"
        state: absent

Great job on this collection! Best regards

djdanielsson commented 1 year ago

you are correct it shouldn't be set to mandatory, we will try and get that updated in the next release