search

redhat-cop / infra.leapp

Collection of Ansible roles for automating RHEL in-place upgrades using Leapp.
MIT License
43 stars 33 forks source link

fixing #182 #183

Closed djdanielsson closed 2 months ago

djdanielsson commented 2 months ago

this is a fix for the issue #182 there is no value in using package because Leapp only works on RHEL based systems so using yum and dnf will always work.

jeffmcutter commented 2 months ago

Please see my reply on #182 .

https://github.com/redhat-cop/infra.leapp/issues/182#issuecomment-2078504666

In summary, unless we have evidence that package doesn't work, I think we should stay with package. If we do have evidence that package doesn't work, then analysis-preupg.yml also has package with enablerepo and should also be changed.

djdanielsson commented 2 months ago

I don't see a reason to keep package really, I think we could easily change them all to yum because that will use dnf if available. This isn't a multi OS automation it's strictly for RHEL

djdanielsson commented 2 months ago

That being said, I would need to search where else we use package and change those if we do that so don't merge this

jeffmcutter commented 2 months ago

Can you help me to understand what the problem is with package? Previously, I was instructed that it is the "best" option. I've never seen a problem with it. For #182 package wasn't the issue.

djdanielsson commented 2 months ago

that is fine, I personally don't care that much either way.