search

redhat-cop / jboss_eap

[DEPRECATED] - Ansible role to install JBoss EAP
Apache License 2.0
30 stars 47 forks source link

Added the redhat_csp_download module as part of the role. #30

Closed wtcross closed 8 years ago

wtcross commented 8 years ago

This change adds the redhat_csp_download module to the jboss_eap role, since it is dependent on it. Before this change ansible projects that use ansible-galaxy requirements.yml to specify dependencies on upstream roles are not able to function without manually adding this module themselves, which defeats the purpose of requirements.yml.

wtcross commented 8 years ago

I'm going to submit a PR to the rhtconsulting/ansible-middleware-playbooks project that removes the module from the project with example playbooks.

kameshsampath commented 8 years ago

@wtcross, will it not be ideal to have this module added to Ansible core module like how we have jboss_deploy so that users can use them like any other module ?

wtcross commented 8 years ago

@kameshsampath I think that's an excellent idea. Until then this role is broken from a re-use perspective. We can remove the module when it is no longer necessary.

sherl0cks commented 8 years ago

@wtcross I like where you are going with this, but I don't think EAP repo is the right home. We plan to use this module in a lot of roles/repos, not just EAP. CSP download should probably be it's own repo and published to galaxy.

wtcross commented 8 years ago

Thank you for the quick responses to my PR. I think making the module live in its own repository is perfect. I'd encourage you guys to reference this project as an example: https://github.com/cmprescott/ansible-xml

I think it's a great example of a module repository. That said, this PR needs to be treated as a fix until the module is available via its own repo. Right now you can't install this role with ansible-galaxy and have it work correctly.

sherl0cks commented 8 years ago

make sense to me. commit looks good. merging