search

redhat-cop / keepalived-operator

An operator to manage VIPs backed by keepalived
Apache License 2.0
117 stars 36 forks source link

DaemonSet pod priorityclass #108

Closed cedricmckinnie closed 1 year ago

cedricmckinnie commented 1 year ago

Added the ability to specify a PriorityClass to DaemonSet pods. This can be important when using a nodeSelector to make sure that other pods running on those nodes don't preempt Keepalived pods and create unintended imbalances.

cedricmckinnie commented 1 year ago

@raffaelespazzoli Any way you think this could be simplified?

cedricmckinnie commented 1 year ago

@raffaelespazzoli sorry to be a bother but any thoughts/updates on this?

cedricmckinnie commented 1 year ago

@raffaelespazzoli Seeing some build errors preventing the release.

Build error appears to have been caused by a missing image: https://github.com/redhat-cop/keepalived-operator/actions/runs/4358129606/jobs/7631527579#step:3:33

The image appears to have been successfully uploaded: https://github.com/redhat-cop/keepalived-operator/actions/runs/4358129606/jobs/7631419807#step:15:38

Could it be related to the recent updates to https://github.com/redhat-cop/github-workflows-operators ?

raffaelespazzoli commented 1 year ago

I think upgrading the build pipeline to 1.0.5 should fix the issue. I need to test it.

cedricmckinnie commented 1 year ago

Would love to avoid having to fork the template into a ConfigMap for my current use case. Anything I can do to assist here? Many thanks!

raffaelespazzoli commented 1 year ago

This has been released, has it not?

cedricmckinnie commented 1 year ago

Ah indeed it is. Thanks and apologies!