search

redhat-cop / keepalived-operator

An operator to manage VIPs backed by keepalived
Apache License 2.0
118 stars 36 forks source link

Add ability to customize keepalived-template.yaml via ConfigMap #93

Closed cedricmckinnie closed 1 year ago

cedricmckinnie commented 1 year ago

This should provide end users of this operator to customize keepalived-template.yaml by adding a ConfigMap and pointing to it via helm chart. It could be helpful for hard-coding configurations or being able to test changes on the fly when working with the operator without having to rebuild/push or develop locally for some use cases.

raffaelespazzoli commented 1 year ago

it looks good to me.

raffaelespazzoli commented 1 year ago

update on both PR, they look good, but the build system is broken. We have not kept it up to date. I'm trying to get help with it.

cedricmckinnie commented 1 year ago

I actually realized that I need to copy the whole keepalived-template.yaml to a ConfigMap in order for the operator to be able to generate the other resources there. Will circle back with the update soon.

cedricmckinnie commented 1 year ago

As for the build system, I encountered that error when trying to run it locally. Seems to have a hard dependency on go1.17. Try bumping and running a copy of the pipeline on another branch.

raffaelespazzoli commented 1 year ago

@cedricmckinnie can you rebase, there is a conflict after we made all the changes to update the build system