Ansible Version Check - Githubissues

redhat-cop / ocp4-helpernode

This playbook helps set up an "all-in-one" node, that has all the infrastructure/services in order to install OpenShift 4.

335 stars 301 forks source link

Closed christianh814 closed 2 years ago

christianh814 commented 2 years ago

Based on issue #271

In short, we need ansible to check itself to make sure it's running the right version. This should be under pre_task https://github.com/redhat-cop/ocp4-helpernode/blob/main/tasks/main.yml#L13

RishiKumarRay commented 2 years ago

@christianh814 Hi, i have added a taks using this command in pre task

name: Print ansible version debug: msg: "Ansible version is {{ ansible_version.full }}" and this prints the version like this

can i raise a PR if you verify this ?

christianh814 commented 2 years ago

The playbook should fail if the Ansible version is less than 2.9

RishiKumarRay commented 2 years ago

@christianh814 i think that in that case assertion would be best see

name: Verify Ansible version. assert: that: "ansible_version.full is version_compare('2.9', '>=')" msg: > "You must update Ansible to at least 2.9"

RishiKumarRay commented 2 years ago

@christianh814 i have tested this the assetions is passing since i have 2.11 installed so shall i raise a PR ?

christianh814 commented 2 years ago

Yup, go ahead and submit a PR against the devel branch

RishiKumarRay commented 2 years ago

@christianh814 thank you , please review