redhat-cop / ocp4-helpernode

This playbook helps set up an "all-in-one" node, that has all the infrastructure/services in order to install OpenShift 4.
342 stars 303 forks source link

Create critical_services as documented by ansible for use with loop. #300

Closed schabrolles closed 1 year ago

schabrolles commented 1 year ago

When using with recent version of ansible-core (>2.12) playbook crashes with the following error:

module.helpernode.null_resource.config (remote-exec): TASK [Enable restart always for critical services] *****************************
module.helpernode.null_resource.config (remote-exec): fatal: [10.3.98.50]: FAILED! => {"msg": "Invalid data passed to 'loop', it requires a list, got this instead: ['httpd', 'named', 'haproxy'] + [ 'dhcpd' ]. Hint: If you passed a list/dict of just one element, try adding wantlist=True to your lookup invocation or use q/query instead of lookup."}

Some variables set during set_facts.yaml need to be set properly in order to be interpreted as list and not string.

schabrolles commented 1 year ago

Hi there,

Is somebody could have a look at this one. One of our partner cannot deploy Openshift on a bastion with rhel8.6.

prb112 commented 1 year ago

@schabrolles I hit the same recently and used your fix. perhaps mention the install team that references this code? maybe the powervm/powervs?

Thanks for the fix, I used it with my team

prb112 commented 1 year ago

Hey @schabrolles I fixed this with the following:

$ yum remove ansible-core
$ yum install ansible-core-2.12.2-3.el8.ppc64le
schabrolles commented 1 year ago

@here .... hello ... Is there anybody out there ?

Without this kind of patch, helpernode script is not usable anymore with "supported RH distro". Could you please have a look on it ?

prb112 commented 1 year ago

Hi @manojnkumar you might be interested in this one. and the powervs upi related bug.

yussufsh commented 1 year ago

@christianh814 could you please help?

lautou commented 1 year ago

304

yussufsh commented 1 year ago

Thanks @christianh814 for merging this one. 👍

prb112 commented 1 year ago

Thank you