Open etsauer opened 5 years ago
@etsauer so I think this may fit in with a bigger refactor/re-design of the openshift-applier. Maybe we can take a step back to consider some higher level architecture changes, including:
I think if we work the above, the items outlined in this issue may become resolved as well.
We've addressed immediate issues like #91 with PR #97, so this isn't urgent. However, I still believe that the filter_plugin methods should not attempt to verify that a URL returns a healthy response. Specifically, there are two cases we are likely to hit in the future where this will create false negatives:
oc
For this reason, I think that the functionality within the check_file_location should only check for the characteristics of a URL (scheme, hostname, path) instead of actually trying to follow all URLs passed by the user.