redhat-cop / openshift-applier

Used to apply OpenShift objects to an OpenShift Cluster
Apache License 2.0
102 stars 61 forks source link

WIP: Trying to cycle through all directories in tests/ #102

Closed etsauer closed 5 years ago

etsauer commented 5 years ago

What does this PR do?

Brief explanation of the code or documentation change you've made

How should this be tested?

Include commands to run your new feature, and also post-run commands to validate that it worked. (please use code blocks to format code samples)

Is there a relevant Issue open for this?

Provide a link to any open issues that describe the problem you are solving.

Who would you like to review this?

cc: @redhat-cop/openshift-applier

sabre1041 commented 5 years ago

@etsauer this is where I got thus far. It succeeds in looping through the directories

diff --git a/molecule/default/playbook.yml b/molecule/default/playbook.yml
index 0c5dd66..b9bb5d8 100644
--- a/molecule/default/playbook.yml
+++ b/molecule/default/playbook.yml
@@ -6,9 +6,9 @@
       find:
         paths: "{{ playbook_dir }}/../../tests/inventories"
         file_type: directory
-        depth: 1
-        recurse: yes
+        recurse: no
       register: tests
+      delegate_to: localhost
   tasks:
     - include: tasks.yml
       with_items: "{{ tests.files }}"
diff --git a/molecule/default/tasks.yml b/molecule/default/tasks.yml
index 0c79d2f..463ce76 100644
--- a/molecule/default/tasks.yml
+++ b/molecule/default/tasks.yml
@@ -1,10 +1,10 @@
 ---
 - name: Setting Location of Inventory Directory
   set_fact:
-    inventory_dir: "{{ (playbook_dir ~ inventory) | realpath }}"
+    inventory_dir: "{{ inventory.path | realpath }}"
 - name: Include Inventory
   include_vars:
-    dir: "{{inventory}}"
+    dir: "{{ inventory_dir }}/group_vars"
 - name: OpenShift Applier Role
   include_role:
     name: "{{ (playbook_dir ~ '/../../roles/openshift-applier') | realpath }}"

However, it is failing on the pre-post-steps inventory as it is using the galaxy_requirements directory which currently does not support copying to a remote host. @oybed would love your thoughts on how we might be able to support this feature to align with the rest of the files (raw files and templates)

etsauer commented 5 years ago

@sabre1041 updated the branch with some of this. I'm getting the same error now.

etsauer commented 5 years ago

@oybed @sabre1041 closing this, as there is a new implementation coming down the pipe.