search

redhat-cop / openshift-applier

Used to apply OpenShift objects to an OpenShift Cluster
Apache License 2.0
102 stars 61 forks source link

Role pre-checks failing for `oc` versions v4.x #117

Closed makentenza closed 5 years ago

makentenza commented 5 years ago

While trying to use the role with a host using oc client version v4.x the pre-checks are failing due the existing conditional regex_search

The output from v3 to v4 oc client is very different so there is a need to evaluate this check now

oc v3.11.110
kubernetes v1.11.0+d4cacc0
features: Basic-Auth GSSAPI Kerberos SPNEGO
Client Version: version.Info{Major:"4", Minor:"1+", GitVersion:"v4.1.0-201904211700+86afce9-dirty", GitCommit:"86afce9", GitTreeState:"", BuildDate:"2019-04-21T23:20:35Z", GoVersion:"", Compiler:"", Platform:""}
Server Version: version.Info{Major:"1", Minor:"13+", GitVersion:"v1.13.4+81fc896", GitCommit:"81fc896", GitTreeState:"clean", BuildDate:"2019-04-21T23:18:54Z", GoVersion:"go1.11.5", Compiler:"gc", Platform:"linux/amd64"}
tylerauerbeck commented 5 years ago

@oybed Are you still working on this? I have something that looks like it works, but I'd like to get some others input on it.

oybed commented 5 years ago

@tylerauerbeck I had a non-working PoC for this, so if you have something that works, it would be great if you could share. The challenge I ran into is that the output generated by the oc client isn't quite json (even though it is super close). We may want to submit an upstream issue for that. Anyway, if you have something we can use, that's great.