search

redhat-cop / openshift-applier

Used to apply OpenShift objects to an OpenShift Cluster
Apache License 2.0
102 stars 61 forks source link

Introduce 'exclude_tags' #124

Closed bvkin closed 4 years ago

bvkin commented 5 years ago

What does this PR do?

Adds the skip_tags option to be used in the same manner as filter_tags.

How should this be tested?

Specify the skip_tags variable when running openshift_applier against an inventory which has tags set, verify that no objects with the given tag were applied. You can also verify that the filter_tags option still works along with neither option.

Is there a relevant Issue open for this?

resolves #118

Who would you like to review this?

cc: @redhat-cop/openshift-applier

pcarney8 commented 5 years ago

+1 to both things that @oybed said, also i created #127 to change that variable name from filter_tags to include_tags :smile:

oybed commented 5 years ago

Also, please fix the error found by the CI job:

--> Executing Yamllint on files found in /home/travis/build/redhat-cop/openshift-applier/...
    /home/travis/build/redhat-cop/openshift-applier/roles/openshift-applier/tasks/error-on-unsupported.yml
      26:39     error    no new line character at the end of file  (new-line-at-end-of-file)
etsauer commented 4 years ago

@oybed where are we with this?

oybed commented 4 years ago

@etsauer I'll sync with @bvkin to check status and get it done

bvkin commented 4 years ago

@oybed @etsauer I think it's done, but could probably use another review as I made a lot of changes to handle overlapping include_tags and exclude_tags.

oybed commented 4 years ago

Yes, let's do a (final) review today when we get a chance to sync. Noticed a few things that still need some work, but we should be able to get it done quickly.

oybed commented 4 years ago

CI passed - merging.