search

redhat-cop / openshift-applier

Used to apply OpenShift objects to an OpenShift Cluster
Apache License 2.0
102 stars 61 forks source link

Make oc and kubectl a configurable option #129

Closed etsauer closed 4 years ago

etsauer commented 5 years ago

What does this PR do?

I've been asked a bunch lately about openshift and kubernetes are "different". As an example to show how interchangeable they can be to use, I put this little example together in applier, to basically provide the option to swap out oc for kubectl. Thought I'd open a PR in case we thought it was worth having upstream

How should this be tested?

Add -e client=kubectl to any applier command.

Is there a relevant Issue open for this?

n/a

Who would you like to review this?

cc: @redhat-cop/openshift-applier

oybed commented 5 years ago

@etsauer with #130 merged, can you please update this PR to align with that logic re: version check?

etsauer commented 4 years ago

@oybed rebased, and refactored version check logic.

etsauer commented 4 years ago

@oybed ALL CI PASSED!!!! Please review!