redhat-cop / openshift-applier

Used to apply OpenShift objects to an OpenShift Cluster
Apache License 2.0
102 stars 61 forks source link

use ubi instead of centos #157

Closed mcanoy closed 4 years ago

mcanoy commented 4 years ago

What does this PR do?

Changes the base image from centos to the ubi. Changes the default inventory that was missing.

How should this be tested?

build the new image

docker build -t redhat-cop/openshift-applier -f images/openshift-applier/Dockerfile .

use the new image

docker run -u $(id -u)   -v $HOME/.kube/config:/openshift-applier/.kube/config:z -t redhat-cop/openshift-applier

or as an example something like

docker run -u $(id -u) -v $HOME/.kube/config:/openshift-applier/.kube/config:z -v /Users/mcanoy/labs/sonarqube-auth-openshift/example/:/tmp/sonarqube-inventory -e INVENTORY_PATH=/tmp/sonarqube-inventory/inventory -e PLAYBOOK=/tmp/sonarqube-inventory/apply.yml  -t redhat-cop/openshift-applier/labs/sonarqube-auth-openshift/example/:/tmp/sonarqube-inventory -e INVENTORY_PATH=/etc/ansible/hosts  -t redhat-cop/openshift-applier

Is there a relevant Issue open for this?

not that I'm aware of.

Who would you like to review this?

cc: @redhat-cop/openshift-applier

oybed commented 4 years ago

OK, great. Wrote issue https://github.com/redhat-cop/openshift-applier/issues/158 to take care of the default inventory/tests execution.