search

redhat-cop / openshift-applier

Used to apply OpenShift objects to an OpenShift Cluster
Apache License 2.0
102 stars 61 forks source link

Add wait for object role #162

Closed tylerauerbeck closed 4 years ago

tylerauerbeck commented 4 years ago

What does this PR do?

This PR adds a role that checks for a specific object to be in place in a cluster

How should this be tested?

This can be tested with the example found in the README:

```yaml
- hosts: my-test-hosts
  tasks:
  - name: Check for my configmap
    include_role:
      name: roles/wait-for-object
    vars:
      k8s_object: configmap
      k8s_object_name: ldap-config
      k8s_object_namespace: cluster-ops

The values for the variables can be switched out for something that exists in your cluster.

Is there a relevant Issue open for this?

N/A

Who would you like to review this?

cc: @redhat-cop/openshift-applier

oybed commented 4 years ago

@tylerauerbeck this looks like a role used for pre/post steps. We don't want to keep those in the openshift-applier repo itself (we intentionally moved all these roles out of this repo before). I am going to close this PR, but can you please open this PR against another repo where it is a better fit? (we can discuss offline if you'd like).

tylerauerbeck commented 4 years ago

@oybed No problem. Not sure I have a good idea of where else to put this? Is this something that should go with some of our other roles in casl-ansible? Or is there a better repo for this somewhere?

oybed commented 4 years ago

@tylerauerbeck yes, closing your PR kicked getting the work around a CoP galaxy repo into gear. This has been discussed multiple times, but nothing has really happened yet. Hence, I started a new repo yesterday and working on getting the structure in place to allow for Ansible Galaxy Collections to be used. Check it out and please provide input/feedback. https://github.com/redhat-cop/casl-galaxy