🦄 allow applier to process helm charts, iterating over mappings not done yet 🦄

redhat-cop / openshift-applier

Used to apply OpenShift objects to an OpenShift Cluster

Apache License 2.0

102 stars 61 forks source link

🦄 allow applier to process helm charts, iterating over mappings not done yet 🦄 #164

Closed pcarney8 closed 3 years ago

pcarney8 commented 4 years ago

What does this PR do?

allows the applier to do helm template ... | oc apply ...

How should this be tested?

Run the tests playbook ansible-playbook playbooks/openshift-cluster-seed.yml -i tests/inventories/helm-charts

Is there a relevant Issue open for this?

Don't believe so

Who would you like to review this?

cc: @redhat-cop/openshift-applier

etsauer commented 4 years ago

@pcarney8 can you rebase? we fixed the CI in another PR

pcarney8 commented 4 years ago

[x] update README
[x] update helm pre-checks

Later on:

use helmv3 ansible module when merged: https://github.com/ansible-collections/kubernetes/pull/61 https://github.com/ansible/ansible/issues/61546

pcarney8 commented 4 years ago

@etsauer rebased, @oybed updated to include pre-check and README fixed as well

etsauer commented 4 years ago

@pcarney8 not sure why the travis builds aren't showing up in the PR, but the linting is throwing errors: https://travis-ci.org/github/redhat-cop/openshift-applier/jobs/680227448

tylerauerbeck commented 4 years ago

@pcarney8 Any idea if you'll have some time to clean these last few things up?

pcarney8 commented 3 years ago

i don't know what is up with this one:

$ yamllint -c molecule/yamllint.yml .
./tests/files/helm-charts/test-chart/templates/project.yaml
  3:41      error    syntax error: expected <block end>, but found '<scalar>' (syntax)

but the rest are fixed now