redhat-cop / openshift-applier

Used to apply OpenShift objects to an OpenShift Cluster
Apache License 2.0
102 stars 62 forks source link

Introduce support for `helm install` #170

Closed jfilipcz closed 2 years ago

jfilipcz commented 2 years ago

Add support for:

What does this PR do?

This PR introduced a new task for the purpose of providing support for helm install command.

How should this be tested?

Run it against inventory simliar to this one:

- object: Helm Repos
  content:
      - name: Install Helm Chart 
        helm:
          name: "ABC"
          timeout: "15m"

Is there a relevant Issue open for this?

N/A

Who would you like to review this?

cc: @redhat-cop/openshift-applier

jfilipcz commented 2 years ago

Definitely, I've replaced helm template with helm install and remove oc apply part as it's no longer needed

oybed commented 2 years ago

ha - no no - we need to support the template action. Sorry, should have been more clear ... replace helm template with helm {{ helm.command }}

oybed commented 2 years ago

Also, to be consistent with other parts of the openshift-applier inventory, use the word action instead of command

oybed commented 2 years ago

@jfilipcz submitted PR against your PR branch to help with the robustness: https://github.com/jfilipcz/openshift-applier/pull/1

jfilipcz commented 2 years ago

@jfilipcz submitted PR against your PR branch to help with the robustness: jfilipcz#1

Nice thing, I've merged the PR