search

redhat-cop / openshift-applier

Used to apply OpenShift objects to an OpenShift Cluster
Apache License 2.0
102 stars 62 forks source link

Add applier prechecks #55

Closed tylerauerbeck closed 6 years ago

tylerauerbeck commented 6 years ago

What does this PR do?

This PR adds the pre-checks requiring Ansible >= 2.5 and setting the oc_ignore_unknown_parameters flag to false if oc <= 3.6.

It also allows us to add any other necessary pre-checks moving forward.

How should this be tested?

On a machine that has Ansible < 2.5, run the applier. You'll see that it fails with a message showing that it needs to be run with version 2.5 or higher.

On a machine that has oc <= 3.6, run the applier. You'll see that the oc_ignore_unknown_parameters flag is set to false.

Is there a relevant Issue open for this?

resolves #54 resolves #57

Who would you like to review this?

cc: @redhat-cop/openshift-applier

oybed commented 6 years ago

Side-note - I updated your description above to include the github keyword resolves to ensure the issues get closed out when the PR merges

tylerauerbeck commented 6 years ago

@oybed Updated with better descriptions, updated sed and handling for null output. Had to break the checks into two (one for null output and one for version) because null output causes the version check to complain when combining the checks.