search

redhat-cop / openshift-applier

Used to apply OpenShift objects to an OpenShift Cluster
Apache License 2.0
102 stars 61 forks source link

Fixing URL getting /tmp/xyz path for remote execution #77

Closed oybed closed 5 years ago

oybed commented 5 years ago

What does this PR do?

In some cases, when executing on a remote host, the template or file URL will be prepended with the temporary path. This has now been fixed to make sure the URL stays a URL.

How should this be tested?

Run at least 3 tests:

  1. Use an inventory whereas the template is a local file and the seed-host is a remote host

    • validate that the execution works and that the files are sources / objects created correctly

  2. Use an inventory whereas the template is a remote file (URL) and the seed-host is a remote host

    • validate that the execution works and that the files are sources / objects created correctly

  3. Repeat the above 2 for a static file

  4. Repeat the first 2 with param files that are a mixture of local and remote (URL) files

Is there a relevant Issue open for this?

resolves #76

Who would you like to review this?

cc: @redhat-cop/openshift-applier

sabre1041 commented 5 years ago

LGTM. Molecule tests pass