search

redhat-cop / openshift-applier

Used to apply OpenShift objects to an OpenShift Cluster
Apache License 2.0
102 stars 61 forks source link

Add module import switch for python3 support #82

Closed mpreu closed 5 years ago

mpreu commented 5 years ago

When using Python3 use urllib.parse instead of urlparse.

What does this PR do?

Changing the package import of urljoin to be compatible with Python2 and Python3

How should this be tested?

Run the applier with an ansible package using python3 by default as in Fedora 29 with ansible in versions 2.7.1 and 2.6.5.

Is there a relevant Issue open for this?

81

Who would you like to review this?

cc: @redhat-cop/openshift-applier

makentenza commented 5 years ago

Thanks, @mpreu, already tested here.

LGTM