search

redhat-cop / openshift-toolkit

A collection of code samples to help you get started with OpenShift
Apache License 2.0
234 stars 150 forks source link

Adding PR template #124

Closed oybed closed 4 years ago

oybed commented 4 years ago

This repo is missing the PR template, etc. Adding an initial template.

@pabrahamsson @garethahealy Can you please review content?

garethahealy commented 4 years ago

@oybed ; we should probably add a section about how to test the PR. Other than that looks fine by me.

oybed commented 4 years ago

@garethahealy yeah, agreed, but intentionally left it out as this repo is a mixed bag of content, so not sure how we wanted to word it. Some other repos have this wording:

How should this be manually tested?
Include commands to run your new feature, and also post-run commands to validate that it worked. (please use code blocks to format code samples)

I know the "manually" part of the above isn't always welcomed, so we could remove that part to make it better. Or, do you have a different suggestion for some text if the above isn't appropriate?

oybed commented 4 years ago

@pabrahamsson @garethahealy can we get a final review/merge on this? I've added a testing section.