redhat-cop / openshift-toolkit

A collection of code samples to help you get started with OpenShift
Apache License 2.0
234 stars 150 forks source link

Ansible playbook for branding console #16

Closed Jooho closed 7 years ago

Jooho commented 7 years ago

PR Description: Ansible playboks are for branding console: changing logo of openshift web console, generating new login page with a new logo.

Contents: This PR contains 2 ansible playbooks :

The roles that the 2 playbooks used are in ansible-galaxy:

etsauer commented 7 years ago

@redhat-cop/cant-contain-this can someone review?

sabre1041 commented 7 years ago

@Jooho I had several issues executing and validating the playbook

The following errors were experienced when attempting to restart OpenShift

Jun 29 23:41:40 master-0.sample.casl.example.com atomic-openshift-master[94598]: Invalid MasterConfig /etc/origin/master/master-config.yaml
Jun 29 23:41:40 master-0.sample.casl.example.com atomic-openshift-master[94598]: oauthConfig.templates.login: Invalid value: "/etc/origin/master/stylesheet/images/new-login.html": template is missing parameter {{ .Error }}
Jun 29 23:41:40 master-0.sample.casl.example.com atomic-openshift-master[94598]: oauthConfig.templates.login: Invalid value: "/etc/origin/master/stylesheet/images/new-login.html": template is missing parameter {{ .Names.CSRF }}
Jun 29 23:41:40 master-0.sample.casl.example.com atomic-openshift-master[94598]: oauthConfig.templates.login: Invalid value: "/etc/origin/master/stylesheet/images/new-login.html": template is missing parameter {{ .Names.Password }}
Jun 29 23:41:40 master-0.sample.casl.example.com atomic-openshift-master[94598]: oauthConfig.templates.login: Invalid value: "/etc/origin/master/stylesheet/images/new-login.html": template is missing parameter {{ .Values.Then }}
Jun 29 23:41:40 master-0.sample.casl.example.com atomic-openshift-master[94598]: oauthConfig.templates.login: Invalid value: "/etc/origin/master/stylesheet/images/new-login.html": template is missing parameter {{ .Values.CSRF }}
Jun 29 23:41:40 master-0.sample.casl.example.com atomic-openshift-master[94598]: oauthConfig.templates.login: Invalid value: "/etc/origin/master/stylesheet/images/new-login.html": template is missing parameter {{ .Values.Username }}
Jun 29 23:41:40 master-0.sample.casl.example.com atomic-openshift-master[94598]: oauthConfig.templates.login: Invalid value: "/etc/origin/master/stylesheet/images/new-login.html": template is missing parameter {{ .Action }}
Jun 29 23:41:40 master-0.sample.casl.example.com atomic-openshift-master[94598]: oauthConfig.templates.login: Invalid value: "/etc/origin/master/stylesheet/images/new-login.html": template is missing parameter {{ .Names.Then }}
Jun 29 23:41:40 master-0.sample.casl.example.com atomic-openshift-master[94598]: oauthConfig.templates.login: Invalid value: "/etc/origin/master/stylesheet/images/new-login.html": template is missing parameter {{ .Names.Username }}
Jooho commented 7 years ago

@sabre1041 oh this ansible was designed to execute from master1 so it didn't need remote_url. However, I think I need to update the script to be executable from anywhere.

I will do it as soon as possible.

Thanks, Jooho Lee.

Jooho commented 7 years ago

@sabre1041

I update scripts. Please test it again after update ansible-galaxy roles : ansible-galaxy install -r requirements.yaml --force

Thanks!

etsauer commented 7 years ago

@Jooho can you rebase your branch?

Jooho commented 7 years ago

@sabre1041 Thanks for your review. Actually it was supposed to execute by root user but now I changed it. So now non privileged user can execute it but still the non privileged user need to be added to sudoers file. Moreover, I add the logic that restart master nodes but sometimes it needs to restart masters manually so I add environment restart_master=false

Lastly, I add video clip for better understanding how it works. Please review it again. Thanks, Jooho Lee.

sabre1041 commented 7 years ago

@Jooho Awesome job. Thanks for working through all the requests and changes. Love the videos too. Very useful for showcasing how to walk through each item.