redhat-cop / openshift-toolkit

A collection of code samples to help you get started with OpenShift
Apache License 2.0
234 stars 150 forks source link

Script does not respect a "no_proxy" env in a proxied environment #50

Open grimkroton opened 6 years ago

grimkroton commented 6 years ago

If running this script behind a proxy, the image pull is running, but the image push to a local registry, which is reachable without a proxy, fails.

The push also uses the proxy, but the local registry is reachable without a proxy.

If a "no_proxy" env is set, the push should not use a proxy.

grimkroton commented 6 years ago

It seems, that this is a bug in the python requests module: https://github.com/requests/requests/issues/879

garethahealy commented 4 years ago

@grimkroton ; which script are you talking about?

grimkroton commented 4 years ago

@garethahealy this script https://raw.githubusercontent.com/redhat-cop/openshift-toolkit/master/disconnected_registry/docker-registry-sync.py Sorry for format, answered from mobile.