fix versioning issues - Githubissues

redhat-cop / openshift-toolkit

A collection of code samples to help you get started with OpenShift

Apache License 2.0

234 stars 150 forks source link

Closed pekramp closed 5 years ago

pekramp commented 6 years ago

Issue when trying to use OpenShift 3.10/3.11 or above original logic assumed only two digits i.e. 3.7, 3.9

Cameronwyatt commented 6 years ago

Please also squash the commits

sabre1041 commented 6 years ago

@Cameronwyatt have you validated the changes in this PR? We can have GH squash the commits if necessary

etsauer commented 5 years ago

@Cameronwyatt @pekramp @sabre1041 this has been open for a little while. Can we get it merged?

pekramp commented 5 years ago

@Cameronwyatt @pekramp @sabre1041 this has been open for a little while. Can we get it merged?

completed Cameron's recommended fixes. This has been tested on our disconnected install for a client with Cameron and Nick Poyant