search

redhat-cop / openshift-toolkit

A collection of code samples to help you get started with OpenShift
Apache License 2.0
234 stars 150 forks source link

Add more logging and proper permissions to image scan #57

Closed etsauer closed 5 years ago

etsauer commented 5 years ago

@JaredBurck @sabre1041 @pabrahamsson

Gl4di4torRr commented 5 years ago

@etsauer nice! For those reviewing, I ran a the image scanner and it took a couple of hours. Not knowing the percentage complete is annoying when you have a large amount of images being scanned.

etsauer commented 5 years ago

@bbeaudoin see updates.

etsauer commented 5 years ago

@bbeaudoin when I look at line 115 and 118, they match. are seeing something different?

sabre1041 commented 5 years ago

@etsauer Running through this resulted in partial success

  1. Docker configuration raised by @bbeaudoin appears to be set up properly as images from the registry is pulled
  2. Images from the Red Hat registry cannot be retrieved as the cluster that I am using leverages images from registry.redhat.io which requires authentication. This would require a subsequent enhancement