redhat-cop / openshift-toolkit

A collection of code samples to help you get started with OpenShift

Apache License 2.0

232 stars 150 forks source link

Updated default-deny and asb networkpolicy. #60

Closed pk-vungle closed 5 years ago

pk-vungle commented 5 years ago

bugzilla for asb networkpolicy: https://bugzilla.redhat.com/show_bug.cgi?id=1469368

There might not be a need for the networkpolicy kube-service-catalog/apiserver.ingress as well if allow-from-same-namespace.yml networkpolicy is applied.

sabre1041 commented 5 years ago

@aelicieguo Thanks for the contribution.

Recent merge brought in an update to the NetworkPolicy API. Would you be able to rebase and resolve the conflicts and we can test and integrate these changes.

pk-vungle commented 5 years ago

@sabre1041 I have just updated the apiversion. These codes were tested with apiversion: networking.k8s.io/v1

sabre1041 commented 5 years ago

@aelicieguo great. Would you be able to rebase from master as there are still conflicts and then we should be good?

pk-vungle commented 5 years ago

@sabre1041 Done. should be good to go.

sabre1041 commented 5 years ago

@aelicieguo did you push the changes to your fork? I do not see any recent changes

pk-vungle commented 5 years ago

It should be the okay? [pchoo@localhost openshift-toolkit]$ git status

On branch master

nothing to commit, working directory clean

sabre1041 commented 5 years ago

@aelicieguo looks good. merging