search

redhat-cop / openshift-toolkit

A collection of code samples to help you get started with OpenShift
Apache License 2.0
232 stars 150 forks source link

Initial PR for #73 #78

Closed aizuddin85 closed 5 years ago

aizuddin85 commented 5 years ago

@etsauer this initial PR to resolve #73 . Let me know if I heading the right way with this PR then I can continue the enhancement.

etsauer commented 5 years ago

hey @aizuddin85 this looks neat! Can you add some instructions in the readme on how to use the flags so I can test the options?

aizuddin85 commented 5 years ago

@etsauer update README.md for example to run. Agree that by default it should run everything with ability to skip certain tests.

etsauer commented 5 years ago

@aizuddin85 can you make that change to the .ini file to run everything by default please?

aizuddin85 commented 5 years ago

@etsauer did several changes and update pytest.ini to run all as default.

aizuddin85 commented 5 years ago

Closing this one. Create new PR #81

etsauer commented 5 years ago

@aizuddin85 hey, I merged #81. In the future, you don't need to close PRs. You can just push new commits to the same branch to address comments. That way we maintain the conversations we had around the change.

aizuddin85 commented 5 years ago

@etsauer thanks for accepting the PR. Reason behind I closed this PR due to too many merge conflicts that I wrongly introduced when I fetched from upstream. Still learning the best way to fix multiple merge conflicts. :-)