search

redhat-cop / osia

Tool for reliable automated deployments of OpenShift Container Platform 4.x into OpenStack and AWS.
https://osia-python.rtfd.io
Apache License 2.0
12 stars 12 forks source link

Fix reference to cloud_env in README and config.py #43

Closed accorvin closed 2 years ago

accorvin commented 2 years ago

The readme and error message in config.py have references to a config option base_env for specifying the environment when one is not specified on the command line. The config.py code, however, looks for a config option called cloud_env (if I'm interpreting the code correctly). This change updates the error message and README to use the proper config option.

mijaros commented 2 years ago

@accorvin thank you for the fix, I'm going to release this as a 0.2.0-alpha7 so the fix should be available soon.

mijaros commented 2 years ago

@accorvin I found that there is one minor thing - I'll add a PR fixing it and link it with yours (base it onto this branch) - the naming convention is broken with the cli. Again thank you very much, good catch.