Fix for #127. - Githubissues

redhat-cop / pathfinder

Apache License 2.0

41 stars 37 forks source link

Fix for #127. #205

Closed dobozysaurus closed 4 years ago

dobozysaurus commented 4 years ago

This fix does a few things:

Moves QuestionReader to a separate class, which was the original ask for the bug.
Loads the survey JSON from a separate file, outside of JS, which was the ask on a related bug.
Fixes some documentation on how to run pathfinder locally.
Fixes some items in run-local.sh, which was causing pathfinder to not load properly when running locally.
Updates Jetty to 9.4.* for local builds, since that runs the appropriate version of the servlet API.

dobozysaurus commented 4 years ago

@matallen I would, but the acceptance tests currently error out b/c they make reference to a module (pathfinder-server-war) that no longer exists.

dobozysaurus commented 4 years ago

@matallen I took a look at the acceptance tests, and I was able to get them running with some changes (see the latest commit). They all pass. In addition to getting the tests running, I made them work on both mac and linux platforms (the existing tests just run on linux).

noelo commented 4 years ago

@dobozysaurus thanks for this, sorry it took so long to merge

dobozysaurus commented 4 years ago

no problem - happy to help!