redhat-cop / pathfinder

Apache License 2.0
41 stars 37 forks source link

Adding assets2 and moving all external links to the static assets. #230

Closed ianwatsonrh closed 4 years ago

ianwatsonrh commented 4 years ago

Fixes #225

NPM is used to create assets2 in the first place.

If approach is accepted we can use NPM to create all assets.

w3counter tracker is not placed in static assets as this will not work in a disconnected instance

noelo commented 4 years ago

@ianwatsonrh does this break the w3counter functionality ? I understand it won't work in a disconnected environment

ianwatsonrh commented 4 years ago

@noelo The javascript code injected via https://www.w3counter.com/tracker.js?id=129401 injects code that will send analytic information to the external w3counter api endpoint.

As the analytic requests wont work in a disconnected environment, as they wont be able to hit the w3counter api endpoint, I think its sufficient to also leave this in as an external source.

This will result in a single failure to load the src rather than repeated failures that the endpoint is unreachable during application use

ianwatsonrh commented 4 years ago

@noelo changed this to merge to disconnected branch

noelo commented 4 years ago

@ianwatsonrh thanks. Much appreciated