search

redhat-cop / rhel-edge-automation-arch

RHEL for Edge Automation Deployment Architecture
Apache License 2.0
45 stars 33 forks source link

Adding RFE Pipelines Helm Chart #159

Closed jordigilh closed 2 years ago

jordigilh commented 2 years ago

Adds the RFE Pipelines helm chart. The annotation, namespace and labels are the only fields that have been parametrized.

metadata:
  annotations:
  {{- toYaml .Values.pipelines.annotations | nindent 4 }}
  namespace: {{ template "common.names.namespace" $ }}
  labels:
    {{- include "common.labels.labels" . | nindent 4 }}

The other parts of the manifests remain unchanged. @sabre1041 @nasx can you take a look and let me know what you think?

sabre1041 commented 2 years ago

Thanks @jordigilh

You can use the following instead of having to perform the iteration of annotations to simplify the logic

{{ toYaml .Values.pipelines.annotations | nindent 4 }}
jordigilh commented 2 years ago

Thanks @jordigilh

You can use the following instead of having to perform the iteration of annotations to simplify the logic

{{ toYaml .Values.pipelines.annotations | nindent 4 }}

Done.

jordigilh commented 2 years ago

@sabre1041 @nasx any further comments? Otherwise, can we merge this PR?

sabre1041 commented 2 years ago

@jordigilh im ok. there are plenty of areas of where additional variables can be included in this chart, but can be a followup task

sabre1041 commented 2 years ago

@jordigilh are you planning on incorporating the Subscription into this chart?

jordigilh commented 2 years ago

@jordigilh are you planning on incorporating the Subscription into this chart?

Was not planning, but I can add it. What do you think?

sabre1041 commented 2 years ago

@jordigilh are you planning on incorporating the Subscription into this chart?

Was not planning, but I can add it. What do you think?

Personally... im almost feeling like we want to just keep the Subscriptions etc completely separate (for everything, not just this chart). Mainly because of the baseline complexities working with the OLM. @nasx interested in your thoughts so we can provide the best path forward. Having the generic operator chart makes it possible to manage the lifecycles separately.