search

redhat-cop / rhel-edge-automation-arch

RHEL for Edge Automation Deployment Architecture
Apache License 2.0
45 stars 33 forks source link

Adding User Workload Monitoring Helm Chart #160

Closed jordigilh closed 2 years ago

jordigilh commented 2 years ago

Adds the User Workload Monitoring helm chart.

@sabre1041 @nasx please review at your discretion.

/Jordi

sabre1041 commented 2 years ago

@jordigilh a couple comments

  1. The templates currently are located in the tests template directory
  2. Take a look at the inline comments
jordigilh commented 2 years ago

@jordigilh a couple comments

1. The templates currently are located in the `tests` template directory

2. Take a look at the inline comments
  1. Thanks, moved them out of test and into the parent directory.
  2. Which comments are you referring to?
sabre1041 commented 2 years ago

@jordigilh i didnt hit submit for the reviews. apologies. they should be visible now

sabre1041 commented 2 years ago

the destinationNamespace is where the chart itself would be installed which in this case should be openshift-monitoring. Also, I believe that both configmaps get configured in openshift-monitoring. if so, we can replicate the same configuration change so that it uses the namespace of the chart.