search

redhat-cop / rhel-edge-automation-arch

RHEL for Edge Automation Deployment Architecture
Apache License 2.0
45 stars 33 forks source link

Renamed composer types for RHEL to align with release 8.5 #235

Open jordigilh opened 2 years ago

jordigilh commented 2 years ago

In RHEL 8.5, the composer types rhel-edge-commit and rhel-edge-container have been renamed to edge-commit and edge-container respectivelly.

$> cat /etc/redhat-release 
Red Hat Enterprise Linux release 8.5 (Ootpa)
$> compose-cli compose types |grep edge
edge-commit
edge-container
edge-installer
edge-raw-image
edge-simplified-installer
ygalblum commented 2 years ago

LGTM

sabre1041 commented 2 years ago

@jordigilh should we add the composer type as a variable in the event there is a need to support older versions of RHEL

jordigilh commented 2 years ago

@jordigilh should we add the composer type as a variable in the event there is a need to support older versions of RHEL

I'm already parametrizing it for Fedora/RHEL, we could use that ansible task to tweak the type even further based on the RHEL version. Keep in mind that we'd also have to manage the different port exposed in the image generated by the edge-container type: in RHEL 8.4 is 80 but in RHEL 8.5 they moved to 8080.

sabre1041 commented 2 years ago

@jordigilh sigh you are right :(