search

redhat-developer-demos / quarkus-tutorial

Quarkus Tutorial for https://dn.dev/quarkusmaster
https://redhat-developer-demos.github.io/quarkus-tutorial/
Apache License 2.0
148 stars 86 forks source link

Inconsistent project for reactive section #155

Closed gsmet closed 6 days ago

gsmet commented 1 month ago

In https://redhat-developer-demos.github.io/quarkus-tutorial/quarkus-tutorial/14_reactive.html, the user is encouraged to create a new project from scratch but then we tell them to get to the root of the old project that was created initially:

Then open a new terminal window, and make sure you’re at the root of your tutorial-app project, then run:

This sounds odd?

gsmet commented 1 month ago

Also given until now, we created the projects with the CLI, maybe it's better to be consistent and also enforce the name of this new project?

gsmet commented 1 month ago

Also creating a project with code.quarkus.io will create a resource class in org.acme which might end up being confusing (and impractical given VS Code UI) given we require the com.redhat.developers package.

gsmet commented 1 month ago

Another issue: we don't tell the user to start the project in dev mode before requesting it.

gsmet commented 1 month ago

Mmmmh and the punkapi.com thing appears to be down. And I can't find any reference on it so not sure it still exists?

gsmet commented 1 month ago

/cc @cescoffier the reactive part of the workshop looks broken because of the service being unavailable.

cescoffier commented 1 month ago

@gsmet Great... I don't know anything about this workshop.

kdubois commented 6 days ago

Fixed (as much as possible) in https://github.com/redhat-developer-demos/quarkus-tutorial/pull/163

The punkapi service has been permanently removed. I found the source code and added instructions to deploy it on an Openshift Sandbox.. not ideal but for now this should work. We may want to consider porting it over to Quarkus and adding it as part of the basic tutorial to deploy or something.