search

redhat-developer-tooling / developer-platform-install

Single Installer for all Red Hat Development Tools and more. Download it form Red Hat Developers Portal web site - http://developers.redhat.com/products/devsuite/overview/.
Apache License 2.0
25 stars 29 forks source link

Treat http statuses >=400 as connection errors rather than auth errors #1265

Open jrichter1 opened 6 years ago

jrichter1 commented 6 years ago

Trying to log in started failing with the 'invalid account information' message, yet it was caused by the server returning 500 (internal server error). Would it make more sense to treat such responses as connection errors and leave the authentication error handling solely for 401 responses?

@dgolovin WDYT?

dgolovin commented 6 years ago

The reason is my changes in request service, the fix is here https://github.com/redhat-developer-tooling/developer-platform-install/pull/1264, but some test issues still have to be fixed.