redhat-developer-tooling / developer-platform-install

Single Installer for all Red Hat Development Tools and more. Download it form Red Hat Developers Portal web site - http://developers.redhat.com/products/devsuite/overview/.
Apache License 2.0
25 stars 29 forks source link

Fix installation failures with special characters in path (fix #1129) #1268

Closed jrichter1 closed 6 years ago

jrichter1 commented 6 years ago

don't allow brackets (they confuse powershell) and remove some jdk issue with carets

codecov-io commented 6 years ago

Codecov Report

Merging #1268 into master will decrease coverage by 0.45%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1268      +/-   ##
==========================================
- Coverage   93.42%   92.97%   -0.46%     
==========================================
  Files          43       43              
  Lines        4624     4696      +72     
  Branches      511      798     +287     
==========================================
+ Hits         4320     4366      +46     
- Misses        304      309       +5     
- Partials        0       21      +21
Impacted Files Coverage Δ
browser/model/jdk-install.js 93.22% <100%> (-0.92%) :arrow_down:
browser/directives/pathValidator.js 100% <100%> (ø) :arrow_up:
browser/model/devstudio-autoinstall.js 97.29% <0%> (-2.71%) :arrow_down:
browser/model/helpers/downloader.js 96.13% <0%> (-1.66%) :arrow_down:
browser/model/che.js 95% <0%> (-1.62%) :arrow_down:
browser/pages/account/controller.js 98.61% <0%> (-1.39%) :arrow_down:
browser/model/cdk.js 98.71% <0%> (-1.29%) :arrow_down:
browser/model/devstudio-p2-zip.js 64.4% <0%> (-1.12%) :arrow_down:
browser/model/devstudio-p2.js 81.66% <0%> (-1.1%) :arrow_down:
browser/services/platform.js 97.38% <0%> (-1.05%) :arrow_down:
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e8f2409...12c7057. Read the comment docs.