redhat-developer-tooling / developer-platform-install

Single Installer for all Red Hat Development Tools and more. Download it form Red Hat Developers Portal web site - http://developers.redhat.com/products/devsuite/overview/.
Apache License 2.0
25 stars 29 forks source link

Package icons into the final archive #1281

Closed jrichter1 closed 6 years ago

jrichter1 commented 6 years ago

it turns out the icons needed by sudo prompt on mac were not packaged into the final archive and caused the prompt to fail miserably

codecov-io commented 6 years ago

Codecov Report

Merging #1281 into master will decrease coverage by 0.48%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1281      +/-   ##
==========================================
- Coverage   93.36%   92.88%   -0.49%     
==========================================
  Files          43       43              
  Lines        4553     4637      +84     
  Branches      505      797     +292     
==========================================
+ Hits         4251     4307      +56     
- Misses        302      307       +5     
- Partials        0       23      +23
Impacted Files Coverage Δ
browser/model/helpers/installer.js 100% <100%> (ø) :arrow_up:
browser/services/platform.js 97.05% <100%> (-1.41%) :arrow_down:
browser/model/devstudio-autoinstall.js 97.29% <0%> (-2.71%) :arrow_down:
browser/services/request.js 97.61% <0%> (-2.39%) :arrow_down:
browser/model/helpers/downloader.js 95.53% <0%> (-1.68%) :arrow_down:
browser/model/che.js 95% <0%> (-1.62%) :arrow_down:
browser/pages/account/controller.js 98.61% <0%> (-1.39%) :arrow_down:
browser/model/devstudio-p2-zip.js 64.4% <0%> (-1.12%) :arrow_down:
browser/model/devstudio-p2.js 81.66% <0%> (-1.1%) :arrow_down:
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 846906d...6d4787f. Read the comment docs.