redhat-developer-tooling / developer-platform-install

Single Installer for all Red Hat Development Tools and more. Download it form Red Hat Developers Portal web site - http://developers.redhat.com/products/devsuite/overview/.
Apache License 2.0
25 stars 29 forks source link

Clean up install method #1298

Closed dgolovin closed 6 years ago

dgolovin commented 6 years ago

Remove not needed code from install item install method. Installation order now is based on flatten dependencies graph so there is no reason to check if required components installed, because required components are installed first.

codecov-io commented 6 years ago

Codecov Report

Merging #1298 into master will decrease coverage by 0.61%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1298      +/-   ##
==========================================
- Coverage   93.68%   93.07%   -0.62%     
==========================================
  Files          44       44              
  Lines        4608     4678      +70     
  Branches      503      784     +281     
==========================================
+ Hits         4317     4354      +37     
- Misses        291      299       +8     
- Partials        0       25      +25
Impacted Files Coverage Δ
browser/model/installable-item.js 92.6% <ø> (-2.21%) :arrow_down:
browser/model/devstudio-autoinstall.js 97.29% <0%> (-2.71%) :arrow_down:
browser/services/request.js 97.61% <0%> (-2.39%) :arrow_down:
browser/model/helpers/downloader.js 95.53% <0%> (-1.68%) :arrow_down:
browser/model/che.js 95% <0%> (-1.62%) :arrow_down:
browser/services/platform.js 97.05% <0%> (-1.41%) :arrow_down:
browser/pages/account/controller.js 98.61% <0%> (-1.39%) :arrow_down:
browser/model/jbossfusekaraf.js 98.73% <0%> (-1.27%) :arrow_down:
browser/model/cdk.js 98.74% <0%> (-1.26%) :arrow_down:
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e82e56d...1fb6641. Read the comment docs.