codecov-io
commented
6 years ago Codecov Report
Merging #1332 into master will decrease coverage by
0.5%. The diff coverage is71.42%.
@@ Coverage Diff @@
## master #1332 +/- ##
==========================================
- Coverage 93.67% 93.16% -0.51%
==========================================
Files 46 46
Lines 4788 4857 +69
Branches 533 836 +303
==========================================
+ Hits 4485 4525 +40
- Misses 303 305 +2
- Partials 0 27 +27| Impacted Files | Coverage Δ | |
|---|---|---|
| browser/pages/selection/controller.js | 85.87% <0%> (-1.22%) |
:arrow_down: |
| browser/pages/confirm/controller.js | 89.47% <75%> (ø) |
:arrow_up: |
| browser/model/virtualbox.js | 91.02% <77.77%> (+0.32%) |
:arrow_up: |
| browser/model/devstudio-autoinstall.js | 97.29% <0%> (-2.71%) |
:arrow_down: |
| browser/services/request.js | 97.61% <0%> (-2.39%) |
:arrow_down: |
| browser/pages/install/controller.js | 91.86% <0%> (-1.75%) |
:arrow_down: |
| browser/model/helpers/downloader.js | 95.53% <0%> (-1.68%) |
:arrow_down: |
| browser/model/che.js | 95% <0%> (-1.62%) |
:arrow_down: |
| browser/pages/account/controller.js | 98.61% <0%> (-1.39%) |
:arrow_down: |
| browser/model/cdk.js | 97.6% <0%> (-1.16%) |
:arrow_down: |
| ... and 26 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 0ff836b...ddb0c00. Read the comment docs.
Since we have the isSkipped method I figured we could start using it. It should be a more general solution to the hypervisor choice problem. Also make sure virtualbox is skipped when xhyve is found.