redhat-developer-tooling / developer-platform-install

Single Installer for all Red Hat Development Tools and more. Download it form Red Hat Developers Portal web site - http://developers.redhat.com/products/devsuite/overview/.
Apache License 2.0
25 stars 29 forks source link

Change packaging for macOS to DMG #1353

Closed dgolovin closed 6 years ago

dgolovin commented 6 years ago

Fix #1158 .

codecov-io commented 6 years ago

Codecov Report

Merging #1353 into master will decrease coverage by 1.02%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1353      +/-   ##
==========================================
- Coverage   93.25%   92.22%   -1.03%     
==========================================
  Files          47       47              
  Lines        4847     4966     +119     
  Branches      543      864     +321     
==========================================
+ Hits         4520     4580      +60     
- Misses        327      357      +30     
- Partials        0       29      +29
Impacted Files Coverage Δ
browser/pages/start/controller.js 81.2% <0%> (-18.8%) :arrow_down:
browser/model/devstudio-autoinstall.js 97.29% <0%> (-2.71%) :arrow_down:
browser/pages/install/controller.js 91.86% <0%> (-1.75%) :arrow_down:
browser/model/helpers/downloader.js 95.53% <0%> (-1.68%) :arrow_down:
browser/model/che.js 95% <0%> (-1.62%) :arrow_down:
browser/services/platform.js 98.14% <0%> (-1.48%) :arrow_down:
browser/pages/account/controller.js 98.61% <0%> (-1.39%) :arrow_down:
browser/model/cdk.js 97.6% <0%> (-1.16%) :arrow_down:
browser/model/devstudio-p2-zip.js 64.4% <0%> (-1.12%) :arrow_down:
browser/model/installable-item.js 92.28% <0%> (-1.03%) :arrow_down:
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b70b8a8...ff8c52a. Read the comment docs.

jrichter1 commented 6 years ago

Looks like no functionality gets broken by this (yay), so I'm trying to sum up what else would need to be changed (meh). So far I got this (anything missing?):

So if all the parties involved get updated, it should be good to go.

dgolovin commented 6 years ago

@jrichter1 We should put our build script to git as well, so we can fix them at the same time.

dgolovin commented 6 years ago

@jrichter1 this also opens opportunity to create shell script or app to uninstall on mac and put it next to installer inside dmg.

dgolovin commented 6 years ago

@jrichter1 I've tested installation for bundled installer and it worked for me, should we merge this PR?

jrichter1 commented 6 years ago

It seems I'll need to change the way system tests launch on mac. I'm going to push it here and that should be enough to merge.

jrichter1 commented 6 years ago

looks like we are good to go