search

redhat-developer-tooling / developer-platform-install

Single Installer for all Red Hat Development Tools and more. Download it form Red Hat Developers Portal web site - http://developers.redhat.com/products/devsuite/overview/.
Apache License 2.0
25 stars 29 forks source link

Update Group Name when no DevStudio and CDK installed #1377

Closed dgolovin closed 6 years ago

dgolovin commented 6 years ago

Fix removes 'Miscellaneous' from title of the group dedicated to show comonents installed that are not related to cdk or devstudio. It also removes 'other' from group's description.

'Miscellaneous Installed Components' group when DevStudio orCDK installed

image

'Installed Components' group when DevStudio and CDK have not been installed

image

codecov-io commented 6 years ago

Codecov Report

Merging #1377 into master will decrease coverage by 0.51%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1377      +/-   ##
==========================================
- Coverage    92.7%   92.19%   -0.52%     
==========================================
  Files          47       47              
  Lines        4891     4968      +77     
  Branches      549      864     +315     
==========================================
+ Hits         4534     4580      +46     
- Misses        357      359       +2     
- Partials        0       29      +29
Impacted Files Coverage Δ
browser/model/devstudio-autoinstall.js 97.29% <0%> (-2.71%) :arrow_down:
browser/pages/install/controller.js 91.86% <0%> (-1.75%) :arrow_down:
browser/model/helpers/downloader.js 95.53% <0%> (-1.68%) :arrow_down:
browser/model/che.js 95% <0%> (-1.62%) :arrow_down:
browser/services/platform.js 98.14% <0%> (-1.48%) :arrow_down:
browser/pages/account/controller.js 98.61% <0%> (-1.39%) :arrow_down:
browser/model/cdk.js 97.6% <0%> (-1.16%) :arrow_down:
browser/model/devstudio-p2-zip.js 64.4% <0%> (-1.12%) :arrow_down:
browser/model/installable-item.js 92.28% <0%> (-1.03%) :arrow_down:
browser/model/devstudio-central-p2-zip.js 60.31% <0%> (-0.98%) :arrow_down:
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ed78bf8...25ff8a0. Read the comment docs.

mohitsuman commented 6 years ago

But in the scenario of only having Installed Components and no DevStudio and CDK, we need to change the text for success message. As it mentions Click on Get Started.