search

redhat-developer-tooling / developer-platform-install

Single Installer for all Red Hat Development Tools and more. Download it form Red Hat Developers Portal web site - http://developers.redhat.com/products/devsuite/overview/.
Apache License 2.0
25 stars 29 forks source link

Fix 'clear all' deselecting components while dependents are still selected #1395

Closed jrichter1 closed 6 years ago

jrichter1 commented 6 years ago

Turns out one can select a component with its dependencies in one channel, then switch to a different channel and use 'clear all' to simply deselect the dependencies without the original item.

Example: select Java Development in Guided Development channel -> go to Java Development channel -> click Clear All -> everything in Java Dev channel gets deselected even though Guided Development is still selected

This PR should check if the deselected component still has something depending on it before committing.

jrichter1 commented 6 years ago

test this

codecov-io commented 6 years ago

Codecov Report

Merging #1395 into master will decrease coverage by 0.61%. The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1395      +/-   ##
==========================================
- Coverage   92.67%   92.06%   -0.62%     
==========================================
  Files          47       47              
  Lines        4904     5003      +99     
  Branches      548      865     +317     
==========================================
+ Hits         4545     4606      +61     
- Misses        359      366       +7     
- Partials        0       31      +31
Impacted Files Coverage Δ
browser/pages/selection/controller.js 84.21% <83.33%> (-1.67%) :arrow_down:
browser/model/devstudio-autoinstall.js 97.29% <0%> (-2.71%) :arrow_down:
browser/pages/install/controller.js 91.86% <0%> (-1.75%) :arrow_down:
browser/model/helpers/downloader.js 95.53% <0%> (-1.68%) :arrow_down:
browser/model/che.js 95% <0%> (-1.62%) :arrow_down:
browser/model/jdk-install.js 93.78% <0%> (-1.51%) :arrow_down:
browser/services/platform.js 98.14% <0%> (-1.48%) :arrow_down:
browser/pages/account/controller.js 98.61% <0%> (-1.39%) :arrow_down:
browser/model/cdk.js 97.6% <0%> (-1.16%) :arrow_down:
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d95157c...a34df9e. Read the comment docs.