Closed jrichter1 closed 6 years ago
Merging #1403 into master will decrease coverage by
0.55%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #1403 +/- ##
==========================================
- Coverage 92.57% 92.02% -0.56%
==========================================
Files 47 47
Lines 4930 5002 +72
Branches 551 864 +313
==========================================
+ Hits 4564 4603 +39
- Misses 366 367 +1
- Partials 0 32 +32
Impacted Files | Coverage Δ | |
---|---|---|
browser/services/platform.js | 97.39% <100%> (-2.23%) |
:arrow_down: |
browser/model/devstudio-autoinstall.js | 97.29% <0%> (-2.71%) |
:arrow_down: |
browser/pages/install/controller.js | 91.86% <0%> (-1.75%) |
:arrow_down: |
browser/model/helpers/downloader.js | 95.53% <0%> (-1.68%) |
:arrow_down: |
browser/model/che.js | 95% <0%> (-1.62%) |
:arrow_down: |
browser/model/jdk-install.js | 93.78% <0%> (-1.51%) |
:arrow_down: |
browser/pages/account/controller.js | 98.61% <0%> (-1.39%) |
:arrow_down: |
browser/model/cdk.js | 97% <0%> (-1.15%) |
:arrow_down: |
browser/model/devstudio-p2-zip.js | 64.4% <0%> (-1.12%) |
:arrow_down: |
... and 25 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update b1400a7...3209354. Read the comment docs.
I have also tested without this fix and xhyve was not detected.
when run from dmg, the installer has its PATH limited to
/usr/bin:/bin:/usr/sbin:/sbin
no idea why, but since xhyve is usually in/usr/local/bin
we should look there as well