Fix gosec warnings - Githubissues

redhat-developer / alizer

⛔️ DEPRECATED - Application analyzer toolkit, use https://github.com/devfile/alizer instead

Apache License 2.0

12 stars 17 forks source link

Fix gosec warnings #224

Closed thepetk closed 1 year ago

thepetk commented 1 year ago

What does this PR do?

Fixes several warnings from gosec security check:

Potential file inclusion: It fixes the issue by using the filepath.Clean() func before using the os.Open() func.
Defering unsafe method: Adds error handling cases inside defer funcs used for file.Close() funcs.
Errors unhandled: For each Unmarshal() func used without error handling, it adds the appropriate error handling.

Which issue(s) does this PR fix

Fixes #222

PR acceptance criteria

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.

[x] Unit/Functional tests
[x] Documentation

How to test changes / Special notes to the reviewer